(Fields PR 2) refact!: FieldClass with named props
#7608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
distantnative
commented
Sep 28, 2025
distantnative
commented
Sep 28, 2025
distantnative
added
needs: discussion 🗣
distantnative
commented
Oct 12, 2025
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
2 times, most recently
from
560bfcd to
f9e6fd7
Compare
1 task
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
from
f9e6fd7 to
14fb5c2
Compare
distantnative
force-pushed
the
v6/refact/fields-named-args
branch
2 times, most recently
from
5dd5edd to
48baca2
Compare
distantnative
removed
needs: discussion 🗣
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
from
48baca2 to
ba4bdc3
Compare
bastianallgeier
changed the base branch from
v6/develop
to
v6/refact/field-mixins
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
4 times, most recently
from
d341043 to
df26bc3
Compare
bastianallgeier
force-pushed
the
v6/refact/field-mixins
branch
from
c5ba308 to
88e6827
Compare
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
from
8016b5b to
9b25a7c
Compare
1 task
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
from
9b25a7c to
a1e719b
Compare
bastianallgeier
force-pushed
the
v6/refact/fields-named-args
branch
from
a1e719b to
f244daf
Compare
bastianallgeier
changed the title
FieldClass with named propsFieldClass with named props (Fields PR 2)
bastianallgeier
changed the title
FieldClass with named props (Fields PR 2)FieldClass with named props
This was referenced Nov 24, 2025
Member
|
@distantnative it's your PR, but I think you should still have another look after my changes. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todo
Next
...$propsChangelog
✨ Enhancements
FieldClass::validate()method that runs all validations.FieldClass::factory()method, which is used in Fields to create instances from arraysKirby\Form\Mixin\Siblingstrait♻️ Refactored
🚨 Breaking changes
FieldClass::setSiblings()is now public and siblings are injected after the construction. Setters can no longer rely on the siblings collection. Use getters or overwrite the::setModelmethod if necessary.FieldClass::setModel()is now public and the model is injected after the construction. Setters can no longer rely on the model. Use getters or overwrite the::setModelmethod if necessary.FIeldClass::fill()instead to provide an initial value.Docs
For review team